markuskreukniet/irmago-measurements: revocation.go; 28 LoC

Found a possible issue in [markuskreukniet/irmago-measurements](https://www.github.com/markuskreukniet/irmago-measurements) at [revocation.go](https://github.com/markuskreukniet/irmago-measurements/blob/1a240f35ff134b563813521fac4397f283c18a07/revocation.go#L718-L745)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to id is reassigned at line 730

[Click here to see the code in its original context.](https://github.com/markuskreukniet/irmago-measurements/blob/1a240f35ff134b563813521fac4397f283c18a07/revocation.go#L718-L745)

Click here to show the 28 line(s) of Go which triggered the analyzer.

```go
for id, s := range settings {
if !s.Authority {
if s.Server && s.RevocationServerURL == "" {
return errors.Errorf("revocation server mode for %s requires URL to be configured", id.String())
}
} else {
s.Server = true
if s.RevocationServerURL != "" {
return errors.Errorf("revocation authority mode for %s cannot be combined with URL", id.String())
}
}
if s.Server {
t = &id
}
if s.SSE {
urls, err := updateURL(id, rs.conf, rs.settings)
if err != nil {
return err
}
if rs.close == nil {
rs.close = make(chan struct{})
rs.events = make(chan *sseclient.Event)
go rs.receiveUpdates()
}
url := fmt.Sprintf("%s/revocation/%s/updateevents", urls[0], id.String())
go rs.listenUpdates(id, url)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1a240f35ff134b563813521fac4397f283c18a07

Read revocation.go at lines 718-745 in commit 1a240f35ff134b563813521fac4397f283c18a07, then trace the range-loop id uses, including t and the goroutine calls. Determine whether the reported reassignment can produce an observable incorrect identifier; completion is a Bug, Mitigated, or Desirable Behavior reaction on the issue.

Written by the indexing model from the issue text.