github-vet / github-vet/rangeloop-pointer-findings
zyxar/grace: taskq/queue.go; 10 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [zyxar/grace](https://www.github.com/zyxar/grace) at [taskq/queue.go](https://github.com/zyxar/grace/blob/8bf40d85a7467e2246ed7928d3914c3d0ca741d4/taskq/queue.go#L137-L146)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable c used in defer or goroutine at line 142
[Click here to see the code in its original context.](https://github.com/zyxar/grace/blob/8bf40d85a7467e2246ed7928d3914c3d0ca741d4/taskq/queue.go#L137-L146)
Click here to show the 10 line(s) of Go which triggered the analyzer.
```go
for _, c := range ctxs {
go func() {
select {
case <-ctx.Done():
return
case <-c.Done():
ret <- false
}
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 8bf40d85a7467e2246ed7928d3914c3d0ca741d4
Contributor guide
No contributing guide indexed for this repository
Research direction
Open taskq/queue.go at lines 137-146 and inspect how the goroutine uses the range variable c. Compare the analyzer finding with the surrounding queue behavior; done means classifying the finding as a bug, mitigated, or desirable behavior and recording the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100