github-vet / github-vet/rangeloop-pointer-findings

samdfonseca/flipadelphia: store/redis.go; 10 LoC

Open
#15,791 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [samdfonseca/flipadelphia](https://www.github.com/samdfonseca/flipadelphia) at [store/redis.go](https://github.com/samdfonseca/flipadelphia/blob/8a6c896a8c7d69a0f1b8397ccecd9e31956c0d4f/store/redis.go#L119-L128)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable scope used in defer or goroutine at line 121

[Click here to see the code in its original context.](https://github.com/samdfonseca/flipadelphia/blob/8a6c896a8c7d69a0f1b8397ccecd9e31956c0d4f/store/redis.go#L119-L128)

Click here to show the 10 line(s) of Go which triggered the analyzer.

```go
for _, scope := range scopes.(FlipadelphiaScopeList) {
go func() {
features, err := rdb.GetScopeFeatures([]byte(scope))
if err != nil {
ech <- err
return
}
fch <- features.(FlipadelphiaScopeFeatures)
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 8a6c896a8c7d69a0f1b8397ccecd9e31956c0d4f

Contributor guide

No contributing guide indexed for this repository

Research direction

Open store/redis.go at lines 119-128 and inspect the goroutine's range-variable capture. Compare the analyzer message with the surrounding use of scopes, then leave the requested reaction classification; done means the instance is marked Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, redis
Domain
databases
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.