jenkins-x/jx-promote: pkg/promote/promote.go; 22 LoC

Found a possible issue in [jenkins-x/jx-promote](https://www.github.com/jenkins-x/jx-promote) at [pkg/promote/promote.go](https://github.com/jenkins-x/jx-promote/blob/759a947469f87cf90851bb2dba15e9ff33bac51f/pkg/promote/promote.go#L551-L572)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/jenkins-x/jx-promote/blob/759a947469f87cf90851bb2dba15e9ff33bac51f/pkg/promote/promote.go#L551-L572)

Click here to show the 22 line(s) of Go which triggered the analyzer.

```go
for _, env := range environments {
if pred(&env) {
ns := env.Spec.Namespace
if ns == "" {
return fmt.Errorf("No namespace for environment %s", env.Name)
}
// lets clear the branch name so that we create a new branch for each PR...
o.BranchName = ""
releaseInfo, err := o.Promote(ns, &env, false, count > 0, o.NoPoll)
if err != nil {
return err
}
o.ReleaseInfo = releaseInfo
if !o.NoPoll {
err = o.WaitForPromotion(ns, &env, releaseInfo)
if err != nil {
return err
}
}
count++
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {pred 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 759a947469f87cf90851bb2dba15e9ff33bac51f

Start with pkg/promote/promote.go lines 551-572 at commit 759a947469f87cf90851bb2dba15e9ff33bac51f. Read the analyzer output and inspect how pred and the promotion calls use the range variable. Done means determining whether the reported range-loop pointer finding is a bug, mitigated, or desirable behavior and leaving the requested classification reaction.

Written by the indexing model from the issue text.