github-vet / github-vet/rangeloop-pointer-findings
fishedee/fishgo: src/github.com/fishedee/util/close_func.go; 7 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [fishedee/fishgo](https://www.github.com/fishedee/fishgo) at [src/github.com/fishedee/util/close_func.go](https://github.com/fishedee/fishgo/blob/40f7480777db9e0f06f0c16fb51006300a9514f9/src/github.com/fishedee/util/close_func.go#L43-L49)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable singleHandler used in defer or goroutine at line 47
[Click here to see the code in its original context.](https://github.com/fishedee/fishgo/blob/40f7480777db9e0f06f0c16fb51006300a9514f9/src/github.com/fishedee/util/close_func.go#L43-L49)
Click here to show the 7 line(s) of Go which triggered the analyzer.
```go
for _, singleHandler := range result {
this.waitGroup.Add(1)
go func() {
defer this.waitGroup.Done()
singleHandler()
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 40f7480777db9e0f06f0c16fb51006300a9514f9
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with src/github.com/fishedee/util/close_func.go around lines 43-49 and inspect how singleHandler is used inside the goroutine. Check the surrounding function and available project checks to understand the intended close behavior. Done means the reported range-loop capture warning is addressed without changing the intended handler execution.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100