github-vet / github-vet/rangeloop-pointer-findings

Fransebas/sssh_distribution: Modules/SSH/SSSHServer.go; 22 LoC

Open
#15,757 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Fransebas/sssh_distribution](https://www.github.com/Fransebas/sssh_distribution) at [Modules/SSH/SSSHServer.go](https://github.com/Fransebas/sssh_distribution/blob/f66ae46ec50ba97eb176f9f17081ff284981e576/Modules/SSH/SSSHServer.go#L209-L230)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable newChannel used in defer or goroutine at line 223

[Click here to see the code in its original context.](https://github.com/Fransebas/sssh_distribution/blob/f66ae46ec50ba97eb176f9f17081ff284981e576/Modules/SSH/SSSHServer.go#L209-L230)

Click here to show the 22 line(s) of Go which triggered the analyzer.

```go
for newChannel := range chans {
// Channels have a type, depending on the application level
// I don't really care about any of that because the client cant issue new channel types
// that's why I'm going to implement my own multiplex on top of a channel

// Accept all channels, we don't care about their type,
// Could be bananas for all I know
go func() {
defer func() {
if err := recover(); err != nil {
CustomUtils.CheckPrint(err.(error))
}
}()

channel, requests, err := newChannel.Accept()
if err != nil {
log.Fatalf("Could not accept channel: %v", err)
}

server.AcceptRequests(requests, &channel, &session)
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f66ae46ec50ba97eb176f9f17081ff284981e576

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.