github-vet / github-vet/rangeloop-pointer-findings

jaredwilkening/biogo: examples/gayatri/main.go; 4 LoC

Open
#15,755 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [jaredwilkening/biogo](https://www.github.com/jaredwilkening/biogo) at [examples/gayatri/main.go](https://github.com/jaredwilkening/biogo/blob/7b6cf24ab907afb3ae290d5dfc750836babd23da/examples/gayatri/main.go#L229-L232)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/jaredwilkening/biogo/blob/7b6cf24ab907afb3ae290d5dfc750836babd23da/examples/gayatri/main.go#L229-L232)

Click here to show the 4 line(s) of Go which triggered the analyzer.

```go
for j, seq := range hipats {
sort.Sort(&seq)
fmt.Fprintf(out, "%s/%e: %d\n", seqTable[j], seq[0].weight, seq[0].index)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Sort 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 7b6cf24ab907afb3ae290d5dfc750836babd23da

Contributor guide

No contributing guide indexed for this repository

Research direction

Open examples/gayatri/main.go at lines 229-232 and review the shown analyzer output in context. Compare the range-loop finding with the linked classification descriptions, then leave the appropriate reaction; the issue is done when it has been classified as Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.