github-vet / github-vet/rangeloop-pointer-findings

zimulala/minproxy: server.go; 9 LoC

Open
#15,753 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [zimulala/minproxy](https://www.github.com/zimulala/minproxy) at [server.go](https://github.com/zimulala/minproxy/blob/ff397ed7c98e21e5a41fd8863ab28a778607d772/server.go#L148-L156)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable info used in defer or goroutine at line 151

[Click here to see the code in its original context.](https://github.com/zimulala/minproxy/blob/ff397ed7c98e21e5a41fd8863ab28a778607d772/server.go#L148-L156)

Click here to show the 9 line(s) of Go which triggered the analyzer.

```go
for _, info := range task.OutInfos {
wg.Add(1)
go func() {
if err := info.ReadReply(); err != nil {
info.connAddr = info.conn.Addr()
}
wg.Done()
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ff397ed7c98e21e5a41fd8863ab28a778607d772

Contributor guide

No contributing guide indexed for this repository

Research direction

Read server.go lines 148-156 and inspect how the range-loop variable is used by the goroutine. Decide whether the reported capture is a real bug, mitigated, or desirable behavior, then leave the corresponding reaction on the issue; completion is a classification reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.