github-vet / github-vet/rangeloop-pointer-findings

jamietsao/aws-ssm-env: main.go; 30 LoC

Open
#15,725 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [jamietsao/aws-ssm-env](https://www.github.com/jamietsao/aws-ssm-env) at [main.go](https://github.com/jamietsao/aws-ssm-env/blob/1e73684352da5f1c4a4410e0f9fc0da998ba002a/main.go#L146-L175)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to path was used in a composite literal at line 152

[Click here to see the code in its original context.](https://github.com/jamietsao/aws-ssm-env/blob/1e73684352da5f1c4a4410e0f9fc0da998ba002a/main.go#L146-L175)

Click here to show the 30 line(s) of Go which triggered the analyzer.

```go
for _, path := range paths {

done := false
var nextToken string
for !done {
input := &ssm.GetParametersByPathInput{
Path: &path,
Recursive: &trueBool,
WithDecryption: &trueBool,
}

if nextToken != "" {
input.SetNextToken(nextToken)
}

output, err := client.GetParametersByPath(input)
if err != nil {
return params, err
}

params = append(params, output.Parameters...)

// there are more parameters for this path if nextToken is given in response
if output.NextToken != nil {
nextToken = *output.NextToken
} else {
done = true
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1e73684352da5f1c4a4410e0f9fc0da998ba002a

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.