github-vet / github-vet/rangeloop-pointer-findings
SherpaCash/snowglobed: avalanche/manager.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [SherpaCash/snowglobed](https://www.github.com/SherpaCash/snowglobed) at [avalanche/manager.go](https://github.com/SherpaCash/snowglobed/blob/ea1b7466e2160606d056a28600e961214e71dfe6/avalanche/manager.go#L694-L696)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/SherpaCash/snowglobed/blob/ea1b7466e2160606d056a28600e961214e71dfe6/avalanche/manager.go#L694-L696)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for _, inv := range invs {
req.AddInvVect(&inv)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {AddInvVect 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: ea1b7466e2160606d056a28600e961214e71dfe6
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reading avalanche/manager.go at lines 694-696 and inspect how AddInvVect receives the loop variable. Determine whether this range-loop reference is a bug, mitigated, or desirable behavior using the linked analyzer context, then classify the issue with the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100