github-vet / github-vet/rangeloop-pointer-findings

NetApp/trident: operator/controllers/provisioner/installer/installer.go; 15 LoC

Open
#15,709 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [NetApp/trident](https://www.github.com/NetApp/trident) at [operator/controllers/provisioner/installer/installer.go](https://github.com/NetApp/trident/blob/62ab24d23195b6616334fb7d17fe4a629dda67fe/operator/controllers/provisioner/installer/installer.go#L1009-L1023)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to clusterRoleBinding is reassigned at line 1014

[Click here to see the code in its original context.](https://github.com/NetApp/trident/blob/62ab24d23195b6616334fb7d17fe4a629dda67fe/operator/controllers/provisioner/installer/installer.go#L1009-L1023)

Click here to show the 15 line(s) of Go which triggered the analyzer.

```go
for _, clusterRoleBinding := range clusterRoleBindings {
if clusterRoleBinding.Name == clusterRoleBindingName {
// Found a cluster role binding named trident/trident-csi
log.Infof("A Trident Cluster role binding named '%s' was found by label.", clusterRoleBindingName)

currentClusterRoleBinding = &clusterRoleBinding
createClusterRoleBinding = false
} else {
log.Errorf("a Trident Cluster role binding %s was found by label "+
"but does not meet name '%s' requirement, marking it for deletion",
clusterRoleBinding.Name, clusterRoleBindingName)

unwantedClusterRoleBindings = append(unwantedClusterRoleBindings, clusterRoleBinding)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 62ab24d23195b6616334fb7d17fe4a629dda67fe

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with operator/controllers/provisioner/installer/installer.go around lines 1009-1023 and read the surrounding function to understand how clusterRoleBinding is used after the loop. Check the Go range-loop reference behavior and determine whether the analyzer finding affects the operator. Done means classifying it as Bug, Mitigated, or Desirable Behavior using the linked guidance.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.