github-vet / github-vet/rangeloop-pointer-findings

rekki/blackrock: bench/blackrock.go; 3 LoC

Open
#15,699 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [rekki/blackrock](https://www.github.com/rekki/blackrock) at [bench/blackrock.go](https://github.com/rekki/blackrock/blob/84e77db09dffb1ead93269b49b22bd185f65cbec/bench/blackrock.go#L95-L97)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to v is reassigned at line 96

[Click here to see the code in its original context.](https://github.com/rekki/blackrock/blob/84e77db09dffb1ead93269b49b22bd185f65cbec/bench/blackrock.go#L95-L97)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for i, v := range scored {
out.Hits[i] = &v
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 84e77db09dffb1ead93269b49b22bd185f65cbec

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with bench/blackrock.go lines 95-97 and inspect the surrounding range loop in the linked commit. Determine whether the analyzer finding represents a bug, mitigation, or desirable behavior, then leave the corresponding reaction as described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.