github-vet / github-vet/rangeloop-pointer-findings

coupa/foundation-go: server/server.go; 5 LoC

Open
#15,681 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [coupa/foundation-go](https://www.github.com/coupa/foundation-go) at [server/server.go](https://github.com/coupa/foundation-go/blob/ef488075339005dcf6fea202375489893d43da32/server/server.go#L103-L107)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable hc used in defer or goroutine at line 105

[Click here to see the code in its original context.](https://github.com/coupa/foundation-go/blob/ef488075339005dcf6fea202375489893d43da32/server/server.go#L103-L107)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, hc := range checks {
go func(healthCheck health.HealthChecker) {
buffer <- &wrapper{di: healthCheck.Check(), hc: healthCheck}
}(hc)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ef488075339005dcf6fea202375489893d43da32

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect server/server.go lines 103-107 and compare the analyzer warning with how hc is passed into the goroutine. Use the linked range-loop-capture classification guidance, then mark the issue Bug, Mitigated, or Desirable Behavior with the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.