github-vet / github-vet/rangeloop-pointer-findings

Tencent/bk-bcs: bcs-services/bcs-mesh-manager/api/v1/zz_generated.deepcopy.go; 11 LoC

Open
#15,651 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Tencent/bk-bcs](https://www.github.com/Tencent/bk-bcs) at [bcs-services/bcs-mesh-manager/api/v1/zz_generated.deepcopy.go](https://github.com/Tencent/bk-bcs/blob/da6deda24df3f5accd42e0874ac5419001dc3840/bcs-services/bcs-mesh-manager/api/v1/zz_generated.deepcopy.go#L124-L134)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 129

[Click here to see the code in its original context.](https://github.com/Tencent/bk-bcs/blob/da6deda24df3f5accd42e0874ac5419001dc3840/bcs-services/bcs-mesh-manager/api/v1/zz_generated.deepcopy.go#L124-L134)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal *ComponentState
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = new(ComponentState)
**out = **in
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: da6deda24df3f5accd42e0874ac5419001dc3840

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with bcs-services/bcs-mesh-manager/api/v1/zz_generated.deepcopy.go at lines 124-134 and inspect the reported range-loop reference to val. Determine whether the analyzer finding represents a bug, mitigated case, or desirable behavior, then leave the corresponding reaction on the issue; completion is the selected classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.