github-vet / github-vet/rangeloop-pointer-findings

Tencent/bk-bcs: bcs-mesos/bcs-scheduler/src/types/application.go; 11 LoC

Open
#15,648 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Tencent/bk-bcs](https://www.github.com/Tencent/bk-bcs) at [bcs-mesos/bcs-scheduler/src/types/application.go](https://github.com/Tencent/bk-bcs/blob/da6deda24df3f5accd42e0874ac5419001dc3840/bcs-mesos/bcs-scheduler/src/types/application.go#L1286-L1296)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 1291

[Click here to see the code in its original context.](https://github.com/Tencent/bk-bcs/blob/da6deda24df3f5accd42e0874ac5419001dc3840/bcs-mesos/bcs-scheduler/src/types/application.go#L1286-L1296)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal *Resource
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = new(Resource)
(*in).DeepCopyInto(*out)
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: da6deda24df3f5accd42e0874ac5419001dc3840

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with bcs-mesos/bcs-scheduler/src/types/application.go at lines 1286-1296 and inspect how the range-loop value and Resource map are used. Compare the analyzer's reassignment finding with the surrounding copy behavior, then classify the instance as Bug, Mitigated, or Desirable Behavior and leave the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
Half a day
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.