github-vet / github-vet/rangeloop-pointer-findings
mindreframer/golang-stuff: github.com/youtube/vitess/go/cmd/zkclient2/zkclient2.go; 11 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [mindreframer/golang-stuff](https://www.github.com/mindreframer/golang-stuff) at [github.com/youtube/vitess/go/cmd/zkclient2/zkclient2.go](https://github.com/mindreframer/golang-stuff/blob/53d15293bf83281db8eef4624eeb83b5a2269577/github.com/youtube/vitess/go/cmd/zkclient2/zkclient2.go#L94-L104)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable path used in defer or goroutine at line 99
[Click here to see the code in its original context.](https://github.com/mindreframer/golang-stuff/blob/53d15293bf83281db8eef4624eeb83b5a2269577/github.com/youtube/vitess/go/cmd/zkclient2/zkclient2.go#L94-L104)
Click here to show the 11 line(s) of Go which triggered the analyzer.
```go
for _, path := range paths {
for i := 0; i < 100; i++ {
go func() {
rpcClient := connect()
for true {
get(rpcClient, path, false)
count.Add(1)
}
}()
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 53d15293bf83281db8eef4624eeb83b5a2269577
Contributor guide
No contributing guide indexed for this repository
Research direction
Review github.com/youtube/vitess/go/cmd/zkclient2/zkclient2.go at lines 94-104 and the analyzer message about the range-loop variable path used in a goroutine. Decide whether the finding is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100