github-vet / github-vet/rangeloop-pointer-findings

TheSmallBoat/beacon_mbs_p2p: beacon_mbs_p2p_src_2020.03.20/broker_p2p_module/message_over_p2p.go; 3 LoC

Open
#15,629 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [TheSmallBoat/beacon_mbs_p2p](https://www.github.com/TheSmallBoat/beacon_mbs_p2p) at [beacon_mbs_p2p_src_2020.03.20/broker_p2p_module/message_over_p2p.go](https://github.com/TheSmallBoat/beacon_mbs_p2p/blob/493a4ed7be0a3cb6b4f8528cf3f84d0b76a321d0/beacon_mbs_p2p_src_2020.03.20/broker_p2p_module/message_over_p2p.go#L153-L155)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 154 passes reference to pkt to third-party code

[Click here to see the code in its original context.](https://github.com/TheSmallBoat/beacon_mbs_p2p/blob/493a4ed7be0a3cb6b4f8528cf3f84d0b76a321d0/beacon_mbs_p2p_src_2020.03.20/broker_p2p_module/message_over_p2p.go#L153-L155)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, pkt := range fps.PacketList {
b.SubmitPublishPacketsWorkTask(&pkt)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

The following graphviz dot graph describes paths through the callgraph that could lead to a function which passes a pointer to third-party code:
digraph G {
"(SubmitPublishPacketsWorkTask, 1)" -> {"(PublishMessageWithBroker, 2)";}
"(PublishMessageWithBroker, 2)" -> {}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 493a4ed7be0a3cb6b4f8528cf3f84d0b76a321d0

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.