github-vet / github-vet/rangeloop-pointer-findings

Lonely7th/JServer: controllers/data_droid.go; 23 LoC

Open
#15,605 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Lonely7th/JServer](https://www.github.com/Lonely7th/JServer) at [controllers/data_droid.go](https://github.com/Lonely7th/JServer/blob/a622062f8c08552b104885c714440189c82423c2/controllers/data_droid.go#L17-L39)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/Lonely7th/JServer/blob/a622062f8c08552b104885c714440189c82423c2/controllers/data_droid.go#L17-L39)

Click here to show the 23 line(s) of Go which triggered the analyzer.

```go
for _, item := range *noteList {
rand.Seed(time.Now().UnixNano())
if item.SuccessRate == 0 {
item.SuccessRate = rand.Intn(100)
} else {
a := rand.Intn(5)
event := rand.Intn(2)
switch event {
case 0: //+
if item.SuccessRate+a < 85 {
item.SuccessRate += a
}
break
case 1: //-
if item.SuccessRate-a > 15 {
item.SuccessRate -= a
}
break
}
}
//更新成功率参数
o.Update(&item)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Update 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: a622062f8c08552b104885c714440189c82423c2

Contributor guide

No contributing guide indexed for this repository

Research direction

Read controllers/data_droid.go around lines 17-39 and inspect how the Update call handles item. Decide whether the range-loop pointer behavior is a bug, mitigated, or desirable behavior, then record the appropriate classification reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.