github-vet / github-vet/rangeloop-pointer-findings

defenxor/dsiem: cmd/dtester/main.go; 40 LoC

Open
#15,603 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [defenxor/dsiem](https://www.github.com/defenxor/dsiem) at [cmd/dtester/main.go](https://github.com/defenxor/dsiem/blob/beea45d6b03203ab505eec8a4cfe3e42a1868a40/cmd/dtester/main.go#L233-L272)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable j used in defer or goroutine at line 262

[Click here to see the code in its original context.](https://github.com/defenxor/dsiem/blob/beea45d6b03203ab505eec8a4cfe3e42a1868a40/cmd/dtester/main.go#L233-L272)

Click here to show the 40 line(s) of Go which triggered the analyzer.

```go
for _, j := range v.Rules {
amt := j.Occurrence
if amt > max {
amt = max
}
e := event.NormalizedEvent{}
e.Sensor = progName
e.SrcIP = genIP(j.From, prevFrom, "")
e.DstIP = genIP(j.To, prevTo, e.SrcIP)
e.SrcPort = genPort(j.PortFrom, prevPortFrom, false)
e.DstPort = genPort(j.PortTo, prevPortTo, true)
e.Protocol = genProto(j.Protocol)
e.PluginID = j.PluginID
e.PluginSID = pickOneFromIntSlice(j.PluginSID)
e.Product = pickOneFromStrSlice(j.Product)
e.Category = j.Category
e.SubCategory = pickOneFromStrSlice(j.SubCategory)

prevPortTo = e.DstPort
prevPortFrom = e.SrcPort
prevFrom = e.SrcIP
prevTo = e.DstIP

for i := 0; i < amt; i++ {
swg.Add()
go func(st int, iter int) {
defer swg.Done()
for {
// err := fn(&e, c, st, iter, verbose)
err := fn(&e, c, j.Stage, iter, verbose)
if err != nil {
log.Info(log.M{Msg: "Error: " + err.Error() + ". Retrying in 3 second."})
time.Sleep(3 * time.Second)
continue
}
break
}
}(j.Stage, i)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: beea45d6b03203ab505eec8a4cfe3e42a1868a40

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect cmd/dtester/main.go lines 233-272, focusing on the goroutine inside the range over v.Rules and its use of j.Stage. Confirm whether the goroutine can observe a later range value, then ensure each goroutine uses the intended rule stage. Done means the reported range-loop capture is addressed without changing the generated event behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.