github-vet / github-vet/rangeloop-pointer-findings

redradrat/aws-iam-operator: api/v1beta1/zz_generated.deepcopy.go; 13 LoC

Open
#15,590 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [redradrat/aws-iam-operator](https://www.github.com/redradrat/aws-iam-operator) at [api/v1beta1/zz_generated.deepcopy.go](https://github.com/redradrat/aws-iam-operator/blob/f744056cb1f42bec6402e13a3389df03c60139ba/api/v1beta1/zz_generated.deepcopy.go#L461-L473)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to val is reassigned at line 466

[Click here to see the code in its original context.](https://github.com/redradrat/aws-iam-operator/blob/f744056cb1f42bec6402e13a3389df03c60139ba/api/v1beta1/zz_generated.deepcopy.go#L461-L473)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for key, val := range *in {
var outVal map[PolicyStatementConditionKey]string
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = make(PolicyStatementConditionComparison, len(*in))
for key, val := range *in {
(*out)[key] = val
}
}
(*out)[key] = outVal
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f744056cb1f42bec6402e13a3389df03c60139ba

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect api/v1beta1/zz_generated.deepcopy.go at lines 461-473 in commit f744056cb1f42bec6402e13a3389df03c60139ba. Compare the analyzer warning with Go range-loop variable semantics and determine whether the generated code is a bug, mitigated, or desirable behavior; record the result with the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.