github-vet / github-vet/rangeloop-pointer-findings

NearlyUnique/nitroSlack: NetscalerWatcher.go; 11 LoC

Open
#15,586 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [NearlyUnique/nitroSlack](https://www.github.com/NearlyUnique/nitroSlack) at [NetscalerWatcher.go](https://github.com/NearlyUnique/nitroSlack/blob/3d704a482eb3ee212ba6ee2b93ec0b13e524931a/NetscalerWatcher.go#L49-L59)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable ns used in defer or goroutine at line 52

[Click here to see the code in its original context.](https://github.com/NearlyUnique/nitroSlack/blob/3d704a482eb3ee212ba6ee2b93ec0b13e524931a/NetscalerWatcher.go#L49-L59)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for _, ns := range nw.netscalers {
for _, group := range ns.Groups {
go func(group string) {
if info, err := ns.GetLbGroupInfo(group); err == nil {
go nw.publishChanges(info)
} else {
log.Printf("FAILED [%v]", err)
}
}(group)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 3d704a482eb3ee212ba6ee2b93ec0b13e524931a

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with NetscalerWatcher.go lines 49-59 and inspect how the goroutine uses the range-loop variable ns while processing each group. Check the analyzer finding and any available project checks, then confirm the change preserves GetLbGroupInfo and publishChanges behavior without capturing the wrong value.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.