github-vet / github-vet/rangeloop-pointer-findings

ChaiYuHerng/free5gc-stage3: src/amf/context/amf_ue.go; 6 LoC

Open
#15,581 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ChaiYuHerng/free5gc-stage3](https://www.github.com/ChaiYuHerng/free5gc-stage3) at [src/amf/context/amf_ue.go](https://github.com/ChaiYuHerng/free5gc-stage3/blob/c229a65305d7944ab29fecc7ec164c1e9b41dc51/src/amf/context/amf_ue.go#L687-L692)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to snssai was used in a composite literal at line 689

[Click here to see the code in its original context.](https://github.com/ChaiYuHerng/free5gc-stage3/blob/c229a65305d7944ab29fecc7ec164c1e9b41dc51/src/amf/context/amf_ue.go#L687-L692)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for _, snssai := range mmContext.AllowedNssai {
allowedSnssai := models.AllowedSnssai{
AllowedSnssai: &snssai,
}
ue.AllowedNssai[mmContext.AccessType] = append(ue.AllowedNssai[mmContext.AccessType], allowedSnssai)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c229a65305d7944ab29fecc7ec164c1e9b41dc51

Contributor guide

No contributing guide indexed for this repository

Research direction

Read src/amf/context/amf_ue.go around lines 687-692 and inspect how the range variable snssai is referenced in the composite literal. Confirm the analyzer's concern about the loop-variable reference and verify that the resulting AllowedNssai entries retain the intended values. Done means the reported issue is addressed without changing the intended AMF behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.