github-vet / github-vet/rangeloop-pointer-findings

ChaiYuHerng/free5gc-stage3: src/amf/consumer/nf_discovery.go; 7 LoC

Open
#15,579 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ChaiYuHerng/free5gc-stage3](https://www.github.com/ChaiYuHerng/free5gc-stage3) at [src/amf/consumer/nf_discovery.go](https://github.com/ChaiYuHerng/free5gc-stage3/blob/c229a65305d7944ab29fecc7ec164c1e9b41dc51/src/amf/consumer/nf_discovery.go#L88-L94)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to nfProfile is reassigned at line 89

[Click here to see the code in its original context.](https://github.com/ChaiYuHerng/free5gc-stage3/blob/c229a65305d7944ab29fecc7ec164c1e9b41dc51/src/amf/consumer/nf_discovery.go#L88-L94)

Click here to show the 7 line(s) of Go which triggered the analyzer.

```go
for _, nfProfile := range resp.NfInstances {
ue.TargetAmfProfile = &nfProfile
amfUri = util.SearchNFServiceUri(nfProfile, models.ServiceName_NAMF_COMM, models.NfServiceStatus_REGISTERED)
if amfUri != "" {
break
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c229a65305d7944ab29fecc7ec164c1e9b41dc51

Contributor guide

No contributing guide indexed for this repository

Research direction

Read src/amf/consumer/nf_discovery.go around lines 88-94 and inspect the linked commit context. Start by tracing how resp.NfInstances and ue.TargetAmfProfile are used, then determine whether the analyzer's range-loop reference finding is a bug, mitigated, or desirable behavior. Done means the finding has a justified classification based on the surrounding code.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.