github-vet / github-vet/rangeloop-pointer-findings

daptin/daptin: server/resource/exchange_rest.go; 6 LoC

Open
#15,576 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [daptin/daptin](https://www.github.com/daptin/daptin) at [server/resource/exchange_rest.go](https://github.com/daptin/daptin/blob/3da51dacf3721597f914e98e8e8d5bd12d5b9331/server/resource/exchange_rest.go#L155-L160)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to ra is reassigned at line 158

[Click here to see the code in its original context.](https://github.com/daptin/daptin/blob/3da51dacf3721597f914e98e8e8d5bd12d5b9331/server/resource/exchange_rest.go#L155-L160)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for _, ra := range restExchanges {
if ra.Name == exchangeContext.TargetType {
found = true
selected = &ra
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 3da51dacf3721597f914e98e8e8d5bd12d5b9331

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in server/resource/exchange_rest.go around lines 155-160 and review the range-loop pointer finding linked from the issue. Determine whether the reported reference reassignment is a bug, mitigated, or desirable behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.