github-vet / github-vet/rangeloop-pointer-findings

twitchyliquid64/kcgen: pcb/starlark.go; 3 LoC

Open
#15,506 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [twitchyliquid64/kcgen](https://www.github.com/twitchyliquid64/kcgen) at [pcb/starlark.go](https://github.com/twitchyliquid64/kcgen/blob/3c6106c185d8c320ed75780bac853a8318cb630c/pcb/starlark.go#L2427-L2429)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/twitchyliquid64/kcgen/blob/3c6106c185d8c320ed75780bac853a8318cb630c/pcb/starlark.go#L2427-L2429)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, e := range p.Primitives {
l.Append(&e)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Append 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 3c6106c185d8c320ed75780bac853a8318cb630c

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at pcb/starlark.go lines 2427-2429 in commit 3c6106c185d8c320ed75780bac853a8318cb630c. Inspect how p.Primitives and l.Append are used around this loop, then check whether the referenced range variable can cause incorrect behavior. Classify the finding as Bug, Mitigated, or Desirable Behavior based on that context.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.