github-vet / github-vet/rangeloop-pointer-findings

monarko/fhirgo: R4/resources/bundle.go; 41 LoC

Open
#15,495 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [monarko/fhirgo](https://www.github.com/monarko/fhirgo) at [R4/resources/bundle.go](https://github.com/monarko/fhirgo/blob/ca0a03fb1f7ae88698df606b835f5c31eda02b68/R4/resources/bundle.go#L32-L72)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to entry is reassigned at line 33

[Click here to see the code in its original context.](https://github.com/monarko/fhirgo/blob/ca0a03fb1f7ae88698df606b835f5c31eda02b68/R4/resources/bundle.go#L32-L72)

Click here to show the 41 line(s) of Go which triggered the analyzer.

```go
for _, entry := range b.Entry {
e := &entry
t, err := e.GetResourceType()
if err != nil {
return *b, err
}
bt, err := json.Marshal(e.Resource)
if err != nil {
return *b, err
}
if resultSet != nil && !helpers.SliceContainsString(resultSet, t) {
continue
}
if t == "Patient" {
p := &Patient{}
if err := json.Unmarshal(bt, &p); err != nil {
return *b, err
// continue
}
entry.Resource = *p
entries = append(entries, entry)
} else if t == "Encounter" {
p := &Encounter{}
if err := json.Unmarshal(bt, &p); err != nil {
return *b, err
// continue
}
entry.Resource = *p
entries = append(entries, entry)
} else if t == "Observation" {
p := &Observation{}
if err := json.Unmarshal(bt, &p); err != nil {
return *b, err
// continue
}
entry.Resource = *p
entries = append(entries, entry)
} else {
entries = append(entries, entry)
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ca0a03fb1f7ae88698df606b835f5c31eda02b68

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in R4/resources/bundle.go at lines 32-72 and inspect how the range loop handles entry while converting Patient, Encounter, and Observation resources. Check the existing project tests if available and verify that the analyzer warning is addressed without changing bundle filtering or resource conversion behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.