github-vet / github-vet/rangeloop-pointer-findings

uynap/batRun: batRun.go; 16 LoC

Open
#15,485 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [uynap/batRun](https://www.github.com/uynap/batRun) at [batRun.go](https://github.com/uynap/batRun/blob/e26b1b18a146df2c58d06b82e0ce17adc7c09f72/batRun.go#L239-L254)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable producer used in defer or goroutine at line 244

[Click here to see the code in its original context.](https://github.com/uynap/batRun/blob/e26b1b18a146df2c58d06b82e0ce17adc7c09f72/batRun.go#L239-L254)

Click here to show the 16 line(s) of Go which triggered the analyzer.

```go
for _, producer := range bat.Producers {
task := &Task{TaskQueue: make(chan context.Context, 5)}

go func() {
defer close(task.TaskQueue)
producer(task)
}()

for n := range task.TaskQueue {
select {
case out <- n:
case <-ctx.Done():
return
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e26b1b18a146df2c58d06b82e0ce17adc7c09f72

Contributor guide

No contributing guide indexed for this repository

Research direction

Read batRun.go lines 239-254 at commit e26b1b18a146df2c58d06b82e0ce17adc7c09f72, focusing on the range loop and its goroutine. Determine whether the reported producer capture is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on this issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.