github-vet / github-vet/rangeloop-pointer-findings
coinrust/crex: exchanges/deribit/deribit.go; 22 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [coinrust/crex](https://www.github.com/coinrust/crex) at [exchanges/deribit/deribit.go](https://github.com/coinrust/crex/blob/70f590595260e3a92c4097879d6bfd0a7eebd2b2/exchanges/deribit/deribit.go#L405-L426)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to v was used in a composite literal at line 424
[Click here to see the code in its original context.](https://github.com/coinrust/crex/blob/70f590595260e3a92c4097879d6bfd0a7eebd2b2/exchanges/deribit/deribit.go#L405-L426)
Click here to show the 22 line(s) of Go which triggered the analyzer.
```go
for _, v := range *e {
var direction Direction
if v.Direction == "buy" {
direction = Buy
} else if v.Direction == "sell" {
direction = Sell
}
orders = append(orders, &Order{
ID: v.OrderID,
Symbol: v.InstrumentName,
Price: v.Price.ToFloat64(),
StopPx: v.StopPrice,
Amount: v.Amount,
AvgPrice: v.AveragePrice,
FilledAmount: v.FilledAmount,
Direction: direction,
Type: b.convertOrderType(v.OrderType),
PostOnly: v.PostOnly,
ReduceOnly: v.ReduceOnly,
Status: b.orderStatus(&v),
})
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 70f590595260e3a92c4097879d6bfd0a7eebd2b2
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.