domoinc/kube-valet: pkg/controller/nodeassignment/writer_context.go; 3 LoC

Found a possible issue in [domoinc/kube-valet](https://www.github.com/domoinc/kube-valet) at [pkg/controller/nodeassignment/writer_context.go](https://github.com/domoinc/kube-valet/blob/f0ef8f09fc992bf4182754355af6eb6e9d370e63/pkg/controller/nodeassignment/writer_context.go#L306-L308)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 307 passes reference to node to third-party code

[Click here to see the code in its original context.](https://github.com/domoinc/kube-valet/blob/f0ef8f09fc992bf4182754355af6eb6e9d370e63/pkg/controller/nodeassignment/writer_context.go#L306-L308)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, node := range nodes.Items {
wc.UpdateNodeAssignment(&node, nil)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

The following graphviz dot graph describes paths through the callgraph that could lead to a function which passes a pointer to third-party code:
digraph G {
"(UpdateNodeAssignment, 2)" -> {}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f0ef8f09fc992bf4182754355af6eb6e9d370e63

Start with pkg/controller/nodeassignment/writer_context.go at lines 306-308 and inspect UpdateNodeAssignment, focusing on how the node reference is handled. Use the analyzer context and call graph to decide whether this is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.