github-vet / github-vet/rangeloop-pointer-findings

tlm/bookie: pkg/engine/engine.go; 7 LoC

Open
#15,473 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [tlm/bookie](https://www.github.com/tlm/bookie) at [pkg/engine/engine.go](https://github.com/tlm/bookie/blob/181abaa7a32d5f81088b4090098fb45697618937/pkg/engine/engine.go#L76-L82)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable c used in defer or goroutine at line 79

[Click here to see the code in its original context.](https://github.com/tlm/bookie/blob/181abaa7a32d5f81088b4090098fb45697618937/pkg/engine/engine.go#L76-L82)

Click here to show the 7 line(s) of Go which triggered the analyzer.

```go
for _, c := range e.controllers {
e.waitGroup.Add(1)
go func() {
c.Run(e.stopCh)
e.waitGroup.Done()
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 181abaa7a32d5f81088b4090098fb45697618937

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect pkg/engine/engine.go lines 76-82 and the linked analyzer context, then compare the finding with the repository's intended behavior. Leave the requested reaction classifying it as Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.