github-vet / github-vet/rangeloop-pointer-findings

gluster/glusterd2: glusterd2/commands/volumes/bricks-status.go; 5 LoC

Open
#15,457 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [gluster/glusterd2](https://www.github.com/gluster/glusterd2) at [glusterd2/commands/volumes/bricks-status.go](https://github.com/gluster/glusterd2/blob/54ce5f6f7a714b321b6fb74a34207f66277d64b6/glusterd2/commands/volumes/bricks-status.go#L96-L100)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to b was used in a composite literal at line 98

[Click here to see the code in its original context.](https://github.com/gluster/glusterd2/blob/54ce5f6f7a714b321b6fb74a34207f66277d64b6/glusterd2/commands/volumes/bricks-status.go#L96-L100)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, b := range vol.GetBricks() {
bmap[b.ID.String()] = api.BrickStatus{
Info: brick.CreateBrickInfo(&b),
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 54ce5f6f7a714b321b6fb74a34207f66277d64b6

Contributor guide

No contributing guide indexed for this repository

Research direction

Read glusterd2/commands/volumes/bricks-status.go around lines 96-100 and review how the range variable b is passed into brick.CreateBrickInfo. Verify whether the pointer can produce incorrect brick data, then classify the finding as a bug, mitigated, or desirable behavior and leave the requested reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.