github-vet / github-vet/rangeloop-pointer-findings

jeromelesaux/facerecognition: model/model.go; 23 LoC

Open
#15,408 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [jeromelesaux/facerecognition](https://www.github.com/jeromelesaux/facerecognition) at [model/model.go](https://github.com/jeromelesaux/facerecognition/blob/10512e19f1a4f3b17802d621e0754225f471968f/model/model.go#L167-L189)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable user used in defer or goroutine at line 171

[Click here to see the code in its original context.](https://github.com/jeromelesaux/facerecognition/blob/10512e19f1a4f3b17802d621e0754225f471968f/model/model.go#L167-L189)

Click here to show the 23 line(s) of Go which triggered the analyzer.

```go
for _, user := range fl.Items {
wc.Add(1)
go func() {
defer wc.Done()
for _, img := range user.TrainingImages {
f, err := os.Open(img)
if err == nil {
defer f.Close()
i, _, err := image.Decode(f)
if err == nil {
imgWidth := i.Bounds().Max.X
imgHeight := i.Bounds().Max.Y
if imgWidth < width {
width = imgWidth
}
if imgHeight < height {
height = imgHeight
}
}
}
}
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 10512e19f1a4f3b17802d621e0754225f471968f

Contributor guide

No contributing guide indexed for this repository

Research direction

Read model/model.go around lines 167-189 and inspect how the range variable is used by the goroutine and deferred file close. Compare the reported analyzer warning with the surrounding behavior, then classify the finding as Bug, Mitigated, or Desirable Behavior by leaving the corresponding reaction on this issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.