github-vet / github-vet/rangeloop-pointer-findings
kahgeh/envoyXds: sources/registryplugins/plugins.go; 15 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [kahgeh/envoyXds](https://www.github.com/kahgeh/envoyXds) at [sources/registryplugins/plugins.go](https://github.com/kahgeh/envoyXds/blob/60527b898e1ffd9d53db8bc11be522792653ef6f/sources/registryplugins/plugins.go#L71-L85)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/kahgeh/envoyXds/blob/60527b898e1ffd9d53db8bc11be522792653ef6f/sources/registryplugins/plugins.go#L71-L85)
Click here to show the 15 line(s) of Go which triggered the analyzer.
```go
for _, plugin := range plugins {
waitgroup.Add(1)
go func(p *Plugin, wg *sync.WaitGroup) {
defer wg.Done()
pluginChannel := (*p).run(ctx)
for {
request, more := <-pluginChannel
if !more {
fmt.Printf("[%s] fan in loop terminating, channel closed\n", (*p).getName())
return
}
channel <- request
}
}(&plugin, &waitgroup)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature { 2} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 60527b898e1ffd9d53db8bc11be522792653ef6f
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with sources/registryplugins/plugins.go at lines 71-85 and review the analyzer output attached to this issue. Trace the shown range-loop and pointer usage to determine whether the reported behavior is a bug, mitigated, or desirable behavior; record the appropriate classification when the result is clear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100