github-vet / github-vet/rangeloop-pointer-findings

wwsean08/go-action-sdk: ResponseBuilder.go; 8 LoC

Open
#15,392 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [wwsean08/go-action-sdk](https://www.github.com/wwsean08/go-action-sdk) at [ResponseBuilder.go](https://github.com/wwsean08/go-action-sdk/blob/0f83958051d4d49b775a959d45f180e02d25e501/ResponseBuilder.go#L106-L113)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to element was used in a composite literal at line 109

[Click here to see the code in its original context.](https://github.com/wwsean08/go-action-sdk/blob/0f83958051d4d49b775a959d45f180e02d25e501/ResponseBuilder.go#L106-L113)

Click here to show the 8 line(s) of Go which triggered the analyzer.

```go
for index, element := range noInputPrompt {
// Set the speech response correctly the first time as this could be long
if mode == TEXT_MODE {
noInPrompts[index] = api.SpeechResponse{TextToSpeech: &element, SSML: nil}
} else {
noInPrompts[index] = api.SpeechResponse{TextToSpeech: nil, SSML: &element}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 0f83958051d4d49b775a959d45f180e02d25e501

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with ResponseBuilder.go lines 106-113 at commit 0f83958051d4d49b775a959d45f180e02d25e501 and review the analyzer's range-loop pointer finding. Check the surrounding ResponseBuilder behavior and any available project verification steps; done means deciding whether the finding is a bug, mitigated, or desirable behavior and confirming that classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.