github-vet / github-vet/rangeloop-pointer-findings

kubernetes/kubernetes: pkg/registry/rbac/rest/storage_rbac.go; 28 LoC

Open
#15,386 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kubernetes/kubernetes](https://www.github.com/kubernetes/kubernetes) at [pkg/registry/rbac/rest/storage_rbac.go](https://github.com/kubernetes/kubernetes/blob/0eea524c28ea4c0e4a0d2746184f3dc63ff124b9/pkg/registry/rbac/rest/storage_rbac.go#L213-L240)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to clusterRole was used in a composite literal at line 215

[Click here to see the code in its original context.](https://github.com/kubernetes/kubernetes/blob/0eea524c28ea4c0e4a0d2746184f3dc63ff124b9/pkg/registry/rbac/rest/storage_rbac.go#L213-L240)

Click here to show the 28 line(s) of Go which triggered the analyzer.

```go
for _, clusterRole := range p.ClusterRoles {
opts := reconciliation.ReconcileRoleOptions{
Role: reconciliation.ClusterRoleRuleOwner{ClusterRole: &clusterRole},
Client: reconciliation.ClusterRoleModifier{Client: clientset.ClusterRoles()},
Confirm: true,
}
// ServiceUnavailble error is returned when the API server is blocked by storage version updates
err := retryOnConflictOrServiceUnavailable(retry.DefaultBackoff, func() error {
result, err := opts.Run()
if err != nil {
return err
}
switch {
case result.Protected && result.Operation != reconciliation.ReconcileNone:
klog.Warningf("skipped reconcile-protected clusterrole.%s/%s with missing permissions: %v", rbac.GroupName, clusterRole.Name, result.MissingRules)
case result.Operation == reconciliation.ReconcileUpdate:
klog.V(2).Infof("updated clusterrole.%s/%s with additional permissions: %v", rbac.GroupName, clusterRole.Name, result.MissingRules)
case result.Operation == reconciliation.ReconcileCreate:
klog.V(2).Infof("created clusterrole.%s/%s", rbac.GroupName, clusterRole.Name)
}
return nil
})
if err != nil {
// don't fail on failures, try to create as many as you can
utilruntime.HandleError(fmt.Errorf("unable to reconcile clusterrole.%s/%s: %v", rbac.GroupName, clusterRole.Name, err))
failedReconciliation = true
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 0eea524c28ea4c0e4a0d2746184f3dc63ff124b9

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in pkg/registry/rbac/rest/storage_rbac.go at lines 213-240, reading the range over p.ClusterRoles and the reconciliation call described by the analyzer. Reproduce or verify the reported reference behavior in this loop, then classify the finding and make the smallest confirmed correction, with the reconciliation behavior remaining intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
authorization, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.