github-vet / github-vet/rangeloop-pointer-findings
odeke-em/dts: trie/trie.go; 11 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [odeke-em/dts](https://www.github.com/odeke-em/dts) at [trie/trie.go](https://github.com/odeke-em/dts/blob/ec2daabf2f9078e887405f7bcddb3d79cb65502d/trie/trie.go#L207-L217)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/odeke-em/dts/blob/ec2daabf2f9078e887405f7bcddb3d79cb65502d/trie/trie.go#L207-L217)
Click here to show the 11 line(s) of Go which triggered the analyzer.
```go
for _, child := range children {
pops += 1
go func(ctnptr **TrieNode) {
ctn := *ctnptr
cchChan := ctn.explore()
for ch := range cchChan {
chChan <- ch
}
done <- true
}(&child)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature { 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: ec2daabf2f9078e887405f7bcddb3d79cb65502d
Contributor guide
No contributing guide indexed for this repository
Research direction
Read trie/trie.go lines 207-217 and the surrounding traversal code, focusing on how child is captured and passed to each goroutine. Compare the analyzer report with the actual behavior, then determine whether this is a Bug, Mitigated, or Desirable Behavior. Leave the corresponding reaction once the classification is supported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100