github-vet / github-vet/rangeloop-pointer-findings

open-o11y/opentelemetry-collector-testing: consumer/pdata/generated_trace.go; 4 LoC

Open
#15,327 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [open-o11y/opentelemetry-collector-testing](https://www.github.com/open-o11y/opentelemetry-collector-testing) at [consumer/pdata/generated_trace.go](https://github.com/open-o11y/opentelemetry-collector-testing/blob/85737fa2be57216857202671e9f056f9b39364db/consumer/pdata/generated_trace.go#L484-L487)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 486 may store a reference to el

[Click here to see the code in its original context.](https://github.com/open-o11y/opentelemetry-collector-testing/blob/85737fa2be57216857202671e9f056f9b39364db/consumer/pdata/generated_trace.go#L484-L487)

Click here to show the 4 line(s) of Go which triggered the analyzer.

```go
for i, el := range *es.orig {
wrappers[i] = &origs[i]
newSpan(&el).CopyTo(newSpan(&wrappers[i]))
}

```

Click here to show extra information the analyzer produced.

```
The following graphviz dot graph describes paths through the callgraph that could lead to a function which writes a pointer argument:
digraph G {
"(newSpan, 1)" -> {}
}

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 85737fa2be57216857202671e9f056f9b39364db

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading consumer/pdata/generated_trace.go around lines 484-487 and the analyzer warning about the range variable el. Trace newSpan and its CopyTo call to determine whether the reference can cause incorrect behavior. Done means classifying the finding as Bug, Mitigated, or Desirable Behavior and leaving the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.