github-vet / github-vet/rangeloop-pointer-findings

renproject/mpc: brng/mock/consensus.go; 13 LoC

Open
#15,289 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [renproject/mpc](https://www.github.com/renproject/mpc) at [brng/mock/consensus.go](https://github.com/renproject/mpc/blob/71f4e68af86fbd95962cbe3424e49127a0a9ee22/brng/mock/consensus.go#L145-L157)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/renproject/mpc/blob/71f4e68af86fbd95962cbe3424e49127a0a9ee22/brng/mock/consensus.go#L145-L157)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for _, index := range pc.honestSubset {
var share shamir.VerifiableShare
for _, s := range sharing.Shares {
if s.Share.IndexEq(&index) {
share = s
}
}

c := sharing.Commitment
if !shamir.IsValid(pc.h, &c, &share) {
return pc.done
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {IndexEq 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 71f4e68af86fbd95962cbe3424e49127a0a9ee22

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with brng/mock/consensus.go at lines 145-157 in commit 71f4e68af86fbd95962cbe3424e49127a0a9ee22. Read the behavior of IndexEq and IsValid to determine whether the analyzer finding is a Bug, Mitigated, or Desirable Behavior. Completion is the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.