github-vet / github-vet/rangeloop-pointer-findings

renproject/mpc: brng/brng.go; 8 LoC

Open
#15,283 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [renproject/mpc](https://www.github.com/renproject/mpc) at [brng/brng.go](https://github.com/renproject/mpc/blob/71f4e68af86fbd95962cbe3424e49127a0a9ee22/brng/brng.go#L99-L106)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/renproject/mpc/blob/71f4e68af86fbd95962cbe3424e49127a0a9ee22/brng/brng.go#L99-L106)

Click here to show the 8 line(s) of Go which triggered the analyzer.

```go
for j, share := range shares {
if !share.Share.IndexEq(&brnger.index) {
return ErrIncorrectIndex
}
if !shamir.IsValid(brnger.h, &commitmentsBatch[i][j], &share) {
return ErrInvalidShares
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {IsValid 3} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 71f4e68af86fbd95962cbe3424e49127a0a9ee22

Contributor guide

No contributing guide indexed for this repository

Research direction

Read brng/brng.go lines 99-106 at commit 71f4e68af86fbd95962cbe3424e49127a0a9ee22, then inspect the surrounding range-loop code and the analyzer details. Compare the finding with the linked classification guidance and leave the appropriate reaction; done means this instance is classified.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.