github-vet / github-vet/rangeloop-pointer-findings
zond/diplicity-old: game/game.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [zond/diplicity-old](https://www.github.com/zond/diplicity-old) at [game/game.go](https://github.com/zond/diplicity-old/blob/ba46f296188317e0d3aa3fa93739f140a07a8ab4/game/game.go#L447-L449)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/zond/diplicity-old/blob/ba46f296188317e0d3aa3fa93739f140a07a8ab4/game/game.go#L447-L449)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for _, member := range members {
d.EmitUpdate(&member)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {EmitUpdate 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: ba46f296188317e0d3aa3fa93739f140a07a8ab4
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with game/game.go at lines 447-449 and inspect the surrounding code plus EmitUpdate. Determine whether passing the range-loop variable address is problematic in this context, then classify the finding as Bug, Mitigated, or Desirable Behavior using the linked project guidance. Done means the classification is supported by the code and recorded on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100