github-vet / github-vet/rangeloop-pointer-findings
xyths/qtr: node/node.go; 8 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [xyths/qtr](https://www.github.com/xyths/qtr) at [node/node.go](https://github.com/xyths/qtr/blob/81459a29c764d45a5cce836ec9876db8397934c2/node/node.go#L295-L302)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/xyths/qtr/blob/81459a29c764d45a5cce836ec9876db8397934c2/node/node.go#L295-L302)
Click here to show the 8 line(s) of Go which triggered the analyzer.
```go
for _, c := range candles {
if n.gormDB.First(&c).RecordNotFound() {
n.gormDB.Create(&c)
success++
} else {
duplicate++
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {First 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 81459a29c764d45a5cce836ec9876db8397934c2
Contributor guide
No contributing guide indexed for this repository
Research direction
Read node/node.go at lines 295-302 and inspect the surrounding candle-processing logic. Determine whether passing the range-loop variable to First and Create creates the reported problem, then classify the finding as Bug, Mitigated, or Desirable Behavior as requested; completion is the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100