github-vet / github-vet/rangeloop-pointer-findings

kori/wylt: main.go; 20 LoC

Open
#15,268 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kori/wylt](https://www.github.com/kori/wylt) at [main.go](https://github.com/kori/wylt/blob/069bed0497a40e822cbb12088d072db30450753f/main.go#L86-L105)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable p used in defer or goroutine at line 101

[Click here to see the code in its original context.](https://github.com/kori/wylt/blob/069bed0497a40e822cbb12088d072db30450753f/main.go#L86-L105)

Click here to show the 20 line(s) of Go which triggered the analyzer.

```go
for _, p := range ps {
for _, t := range ts {
playerLog, errs := p.Subscribe()
go func() {
for e := range errs {
// player errors are bound to fill up, should the connection be lost.
// TODO: find a better way to deal with player error logs
log.Println(e)
}
}()

for cur := range playerLog {
go func(cur playerStatus) {
fmt.Println("now playing:", cur.Track.Title, "by", cur.Track.Artist)
t.SubmitPlayingNow(cur.Track)
createTimer(p, t, cur)
}(cur)
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 069bed0497a40e822cbb12088d072db30450753f

Contributor guide

No contributing guide indexed for this repository

Research direction

Read main.go lines 86-105 and inspect how the goroutines use p, t, errs, and cur. Determine whether the analyzer finding represents a real bug, mitigated behavior, or desirable behavior, then record that classification using the issue's reaction options.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.