github-vet / github-vet/rangeloop-pointer-findings
nasmosk/sphere-2017-hakaton2: exchange/exchange.go; 13 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [nasmosk/sphere-2017-hakaton2](https://www.github.com/nasmosk/sphere-2017-hakaton2) at [exchange/exchange.go](https://github.com/nasmosk/sphere-2017-hakaton2/blob/2f872d946f42cf5e7c1cc44d7e136e0aca099d47/exchange/exchange.go#L180-L192)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/nasmosk/sphere-2017-hakaton2/blob/2f872d946f42cf5e7c1cc44d7e136e0aca099d47/exchange/exchange.go#L180-L192)
Click here to show the 13 line(s) of Go which triggered the analyzer.
```go
for _, v := range agregatedOHLCV {
v.Time = int32(time.Now().Hour()*10000 + time.Now().Minute()*100 + time.Now().Second())
v.ID = ID
ID = ID + 1
v.Interval = 1
for _, s := range subscribers {
s.Send(&v)
}
v.Open = v.Close
v.Volume = 0
v.Low = v.Close
v.High = v.Close
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Send 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 2f872d946f42cf5e7c1cc44d7e136e0aca099d47
Contributor guide
No contributing guide indexed for this repository
Research direction
Read exchange/exchange.go lines 180-192 and inspect how the range-loop variable is passed to subscribers through Send. Determine whether the reported pointer behavior is a real bug, mitigated, or desirable behavior; done means leaving the corresponding classification reaction on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100