github-vet / github-vet/rangeloop-pointer-findings

dperny/swarmkit: agent/agent.go; 20 LoC

Open
#15,261 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [dperny/swarmkit](https://www.github.com/dperny/swarmkit) at [agent/agent.go](https://github.com/dperny/swarmkit/blob/323a67340346d21301c73223ca7cd4e829c14519/agent/agent.go#L313-L332)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable task used in defer or goroutine at line 327

[Click here to see the code in its original context.](https://github.com/dperny/swarmkit/blob/323a67340346d21301c73223ca7cd4e829c14519/agent/agent.go#L313-L332)

Click here to show the 20 line(s) of Go which triggered the analyzer.

```go
for _, task := range tasks {
assigned[task.ID] = task
ctx := log.WithLogger(ctx, log.G(ctx).WithField("task.id", task.ID))

if _, ok := a.controllers[task.ID]; ok {
if err := a.updateTask(ctx, task); err != nil {
log.G(ctx).WithError(err).Error("task update failed")
}
continue
}
log.G(ctx).Debugf("assigned")
if err := a.acceptTask(ctx, task); err != nil {
log.G(ctx).WithError(err).Error("starting task controller failed")
go func() {
if err := a.report(ctx, task.ID, api.TaskStateRejected, "rejected task during assignment", err, nil); err != nil {
log.G(ctx).WithError(err).Error("reporting task rejection failed")
}
}()
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 323a67340346d21301c73223ca7cd4e829c14519

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.