github-vet / github-vet/rangeloop-pointer-findings

foomo/shop: pricerule/checkout.go; 11 LoC

Open
#15,237 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [foomo/shop](https://www.github.com/foomo/shop) at [pricerule/checkout.go](https://github.com/foomo/shop/blob/4ed9734ff0c8694a8cf6c2e40afef3b9a47ae1e4/pricerule/checkout.go#L247-L257)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to promotionRule was used in a composite literal at line 251

[Click here to see the code in its original context.](https://github.com/foomo/shop/blob/4ed9734ff0c8694a8cf6c2e40afef3b9a47ae1e4/pricerule/checkout.go#L247-L257)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for _, promotionRule := range promotionPriceRules {
//only add the customer and product promotion if an excluding one has not been applied yet
if promotionRule.Type == TypePromotionCustomer || promotionRule.Type == TypePromotionProduct {
if previousMutualExclusionRule == false {
ruleVoucherPairs = append(ruleVoucherPairs, RuleVoucherPair{Rule: &promotionRule, Voucher: nil})
previousMutualExclusionRule = true
}
} else {
ruleVoucherPairs = append(ruleVoucherPairs, RuleVoucherPair{Rule: &promotionRule, Voucher: nil})
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 4ed9734ff0c8694a8cf6c2e40afef3b9a47ae1e4

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.