github-vet / github-vet/rangeloop-pointer-findings

onurkeskin/idletownsim: game/serverlayer/gameresources/CachedResourceRepository.go; 3 LoC

Open
#15,234 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [onurkeskin/idletownsim](https://www.github.com/onurkeskin/idletownsim) at [game/serverlayer/gameresources/CachedResourceRepository.go](https://github.com/onurkeskin/idletownsim/blob/0d41b7304f88bd5a043097a0d8a411e75d4ce789/game/serverlayer/gameresources/CachedResourceRepository.go#L48-L50)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/onurkeskin/idletownsim/blob/0d41b7304f88bd5a043097a0d8a411e75d4ce789/game/serverlayer/gameresources/CachedResourceRepository.go#L48-L50)

Click here to show the 3 line(s) of Go which triggered the analyzer.

```go
for _, v := range fromdb {
repo.cacheByResourceID.Set(v.ID.Hex(), &v, cache.DefaultExpiration)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 0d41b7304f88bd5a043097a0d8a411e75d4ce789

Contributor guide

No contributing guide indexed for this repository

Research direction

Open game/serverlayer/gameresources/CachedResourceRepository.go at lines 48-50 and review the linked code context. Read the analyzer classification descriptions in the issue, then determine whether the range-loop pointer finding is a Bug, Mitigated, or Desirable Behavior and leave the corresponding reaction; no test or patch is identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.