github-vet / github-vet/rangeloop-pointer-findings
c9s/bbgo: pkg/bbgo/order_execution.go; 9 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [c9s/bbgo](https://www.github.com/c9s/bbgo) at [pkg/bbgo/order_execution.go](https://github.com/c9s/bbgo/blob/d8fb46c3f9f86bb0b2c3875bfee0f9d2dd418fc0/pkg/bbgo/order_execution.go#L62-L70)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/c9s/bbgo/blob/d8fb46c3f9f86bb0b2c3875bfee0f9d2dd418fc0/pkg/bbgo/order_execution.go#L62-L70)
Click here to show the 9 line(s) of Go which triggered the analyzer.
```go
for _, order := range orders {
// pass submit order as an interface object.
channel, ok := e.RouteObject(&order)
if ok {
e.NotifyTo(channel, ":memo: Submitting %s %s %s order with quantity: %s at price: %s", order.Symbol, order.Type, order.Side, order.QuantityString, order.PriceString, &order)
} else {
e.Notify(":memo: Submitting %s %s %s order with quantity: %s at price: %s", order.Symbol, order.Type, order.Side, order.QuantityString, order.PriceString, &order)
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {NotifyTo 8} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: d8fb46c3f9f86bb0b2c3875bfee0f9d2dd418fc0
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with pkg/bbgo/order_execution.go at the referenced lines and inspect RouteObject, NotifyTo, and Notify in the c9s/bbgo commit named in the issue. Determine whether the range-loop order pointer can escape through those calls, then classify the finding as Bug, Mitigated, or Desirable Behavior with a reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100