github-vet / github-vet/rangeloop-pointer-findings
steveoc64/go-cmms: app/site.go; 13 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [steveoc64/go-cmms](https://www.github.com/steveoc64/go-cmms) at [app/site.go](https://github.com/steveoc64/go-cmms/blob/4439dc245af5d5244380c4e0f397dd3ed4dd91f0/app/site.go#L531-L543)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to m1 is reassigned at line 533
[Click here to see the code in its original context.](https://github.com/steveoc64/go-cmms/blob/4439dc245af5d5244380c4e0f397dd3ed4dd91f0/app/site.go#L531-L543)
Click here to show the 13 line(s) of Go which triggered the analyzer.
```go
for _, m1 := range data.Machines {
if m1.ID == d.MachineID {
d.Machine = &m1
// now get the component
for _, c1 := range m1.Components {
if c1.ID == d.CompID {
d.Component = &c1
break
}
}
break
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 4439dc245af5d5244380c4e0f397dd3ed4dd91f0
Contributor guide
No contributing guide indexed for this repository
Research direction
Read app/site.go around lines 531-543 and inspect the referenced range-loop code in the linked commit. Determine whether the analyzer finding is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on this issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100