github-vet / github-vet/rangeloop-pointer-findings
steveoc64/go-cmms: app/site.go; 5 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [steveoc64/go-cmms](https://www.github.com/steveoc64/go-cmms) at [app/site.go](https://github.com/steveoc64/go-cmms/blob/4439dc245af5d5244380c4e0f397dd3ed4dd91f0/app/site.go#L515-L519)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to m1 is reassigned at line 517
[Click here to see the code in its original context.](https://github.com/steveoc64/go-cmms/blob/4439dc245af5d5244380c4e0f397dd3ed4dd91f0/app/site.go#L515-L519)
Click here to show the 5 line(s) of Go which triggered the analyzer.
```go
for _, m1 := range data.Machines {
if m1.ID == d.MachineID {
d.Machine = &m1
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 4439dc245af5d5244380c4e0f397dd3ed4dd91f0
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with app/site.go at lines 515-519 in commit 4439dc245af5d5244380c4e0f397dd3ed4dd91f0, then inspect how d.Machine is used around this loop. Determine whether the analyzer's reported reassignment is a bug, mitigated, or desirable behavior, and classify the finding with the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100