vlado-github/TinyDFS: messaging/messagequeue.go; 10 LoC

Found a possible issue in [vlado-github/TinyDFS](https://www.github.com/vlado-github/TinyDFS) at [messaging/messagequeue.go](https://github.com/vlado-github/TinyDFS/blob/48bd66e3df1df5ad1b6bf1f8e8daec38435ad6d6/messaging/messagequeue.go#L114-L123)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/vlado-github/TinyDFS/blob/48bd66e3df1df5ad1b6bf1f8e8daec38435ad6d6/messaging/messagequeue.go#L114-L123)

Click here to show the 10 line(s) of Go which triggered the analyzer.

```go
for index, message := range queue.messageBuffer {
for _, conn := range queue.pool.conns {
if conn != nil {
encoder := json.NewEncoder(conn)
encodeMessage(&message, encoder)
logging.AddInfo("[Queue] Sending: ", string(message.Payload)+"\n")
}
}
delete(queue.messageBuffer, index)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {encodeMessage 2} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 48bd66e3df1df5ad1b6bf1f8e8daec38435ad6d6

Start with messaging/messagequeue.go lines 114-123 in the cited TinyDFS commit, then inspect encodeMessage and the json.Encoder call. Determine whether the range-loop variable is incorrectly referenced or whether the behavior is safe, and classify the finding with the requested Bug, Mitigated, or Desirable Behavior reaction.

Written by the indexing model from the issue text.